From 5b3736b5333f548069c8588f252ba88b0dd3294d Mon Sep 17 00:00:00 2001 From: Steve Holme Date: Wed, 27 Feb 2013 20:48:24 +0000 Subject: imap: Reversed the logic of the (un)successful tagged CAPABILITY response Reversed the logic of the unsuccessful vs successful tagged CAPABILITY response in imap_state_capability_resp() to be more logical to read. --- lib/imap.c | 30 ++++++++++++++++-------------- 1 file changed, 16 insertions(+), 14 deletions(-) (limited to 'lib') diff --git a/lib/imap.c b/lib/imap.c index 671f206d3..cfde0019a 100644 --- a/lib/imap.c +++ b/lib/imap.c @@ -810,23 +810,25 @@ static CURLcode imap_state_capability_resp(struct connectdata *conn, line += wordlen; } } - else if(imapcode != 'O') - result = imap_state_login(conn); - else if(data->set.use_ssl && !conn->ssl[FIRSTSOCKET].use) { - /* We don't have a SSL/TLS connection yet, but SSL is requested */ - if(imapc->tls_supported) - /* Switch to TLS connection now */ - result = imap_state_starttls(conn); - else if(data->set.use_ssl == CURLUSESSL_TRY) - /* Fallback and carry on with authentication */ - result = imap_authenticate(conn); - else { - failf(data, "STARTTLS not supported."); - result = CURLE_USE_SSL_FAILED; + else if(imapcode == 'O') { + if(data->set.use_ssl && !conn->ssl[FIRSTSOCKET].use) { + /* We don't have a SSL/TLS connection yet, but SSL is requested */ + if(imapc->tls_supported) + /* Switch to TLS connection now */ + result = imap_state_starttls(conn); + else if(data->set.use_ssl == CURLUSESSL_TRY) + /* Fallback and carry on with authentication */ + result = imap_authenticate(conn); + else { + failf(data, "STARTTLS not supported."); + result = CURLE_USE_SSL_FAILED; + } } + else + result = imap_authenticate(conn); } else - result = imap_authenticate(conn); + result = imap_state_login(conn); return result; } -- cgit v1.2.3