From 65fda739ee35c090b2e6d91229287de734f0fbae Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Sat, 24 Aug 2019 10:45:18 +0200 Subject: http: the 'closed' struct field is used by both ngh2 and ngh3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit and remove 'header_recvbuf', not used for anything Reported-by: Jeremy Lainé Closes #4257 --- lib/http.h | 2 +- lib/vquic/ngtcp2.c | 6 ------ 2 files changed, 1 insertion(+), 7 deletions(-) (limited to 'lib') diff --git a/lib/http.h b/lib/http.h index 6232bbc3a..5bacb1754 100644 --- a/lib/http.h +++ b/lib/http.h @@ -176,7 +176,6 @@ struct HTTP { int status_code; /* HTTP status code */ const uint8_t *pausedata; /* pointer to data received in on_data_chunk */ size_t pauselen; /* the number of bytes left in data */ - bool closed; /* TRUE on HTTP2 stream close */ bool close_handled; /* TRUE if stream closure is handled by libcurl */ char **push_headers; /* allocated array */ @@ -184,6 +183,7 @@ struct HTTP { size_t push_headers_alloc; /* number of entries allocated */ #endif #if defined(USE_NGHTTP2) || defined(USE_NGHTTP3) + bool closed; /* TRUE on HTTP2 stream close */ char *mem; /* points to a buffer in memory to store received data */ size_t len; /* size of the buffer 'mem' points to */ size_t memlen; /* size of data copied to mem */ diff --git a/lib/vquic/ngtcp2.c b/lib/vquic/ngtcp2.c index 008a75cfd..1cdbb7d39 100644 --- a/lib/vquic/ngtcp2.c +++ b/lib/vquic/ngtcp2.c @@ -1784,12 +1784,6 @@ static CURLcode http_request(struct connectdata *conn, const void *mem, } } - stream->header_recvbuf = Curl_add_buffer_init(); - if(!stream->header_recvbuf) { - result = CURLE_OUT_OF_MEMORY; - goto fail; - } - switch(data->set.httpreq) { case HTTPREQ_POST: case HTTPREQ_POST_FORM: -- cgit v1.2.3