From b685481d527309d595ebf3551048a9f96975dc9e Mon Sep 17 00:00:00 2001 From: Steve Holme Date: Sat, 7 Jan 2012 13:42:28 +0000 Subject: smtp.c: Fixed use of angled brackets in AUTH parameter. Fixed the use of angled brackets "<>" in the optional AUTH parameter as per RFC-2554 section 5. The address should not include them but an empty address should be replaced by them. --- lib/smtp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'lib') diff --git a/lib/smtp.c b/lib/smtp.c index c02c9bdd4..fa5452aff 100644 --- a/lib/smtp.c +++ b/lib/smtp.c @@ -912,10 +912,11 @@ static CURLcode smtp_mail(struct connectdata *conn) /* calculate the optional AUTH parameter */ if(data->set.str[STRING_MAIL_AUTH] && conn->proto.smtpc.authused) { - if(data->set.str[STRING_MAIL_AUTH][0] == '<') + if(data->set.str[STRING_MAIL_AUTH][0] != '\0') auth = aprintf("%s", data->set.str[STRING_MAIL_AUTH]); else - auth = aprintf("<%s>", data->set.str[STRING_MAIL_AUTH]); + /* empty AUTH, RFC-2554, sect. 5 */ + auth = strdup("<>"); if(!auth) { Curl_safefree(from); -- cgit v1.2.3