From b85c625d831de821d0e4ead3d01be2ffe955aa28 Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Thu, 2 Oct 2014 23:31:01 +0200 Subject: detect_proxy: fix possible single-byte memory leak Coverity CID 1202836. If the proxy environment variable returned an empty string, it would be leaked. While an empty string is not really a proxy, other logic in this function already allows a blank string to be returned so allow that here to avoid the leak. --- lib/url.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'lib') diff --git a/lib/url.c b/lib/url.c index 69a75e310..0ee6fb042 100644 --- a/lib/url.c +++ b/lib/url.c @@ -4339,9 +4339,8 @@ static char *detect_proxy(struct connectdata *conn) prox=curl_getenv(proxy_env); } - if(prox && *prox) { /* don't count "" strings */ + if(prox) proxy = prox; /* use this */ - } else { proxy = curl_getenv("all_proxy"); /* default proxy to use */ if(!proxy) -- cgit v1.2.3