From c6b97a8278f3c2297a99bee877cc0a5bb13e5761 Mon Sep 17 00:00:00 2001 From: Kamil Dudka Date: Thu, 4 Nov 2010 21:44:02 +0100 Subject: ftp: close connection as soon as ABOR has been sent ... and do not send ABOR unless really necessary. Bug: https://bugzilla.redhat.com/649347 Reported by: Simon H. --- lib/ftp.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) (limited to 'lib') diff --git a/lib/ftp.c b/lib/ftp.c index 679f2334c..d79878e82 100644 --- a/lib/ftp.c +++ b/lib/ftp.c @@ -3083,10 +3083,9 @@ static CURLcode ftp_done(struct connectdata *conn, CURLcode status, #endif if(conn->sock[SECONDARYSOCKET] != CURL_SOCKET_BAD) { - if(!result && ftpc->dont_check) - /* prevent some FTP servers (namely Pure-ftpd) from hanging if we close - * the data channel before transferring all data */ - result = Curl_pp_sendf(&ftpc->pp, "ABOR"); + if(!result && ftpc->dont_check && data->req.maxdownload > 0) + /* partial download completed */ + result = Curl_pp_sendf(pp, "ABOR"); if(conn->ssl[SECONDARYSOCKET].use) { /* The secondary socket is using SSL so we must close down that part @@ -3128,6 +3127,14 @@ static CURLcode ftp_done(struct connectdata *conn, CURLcode status, if(result) return result; + if(ftpc->dont_check && data->req.maxdownload > 0) { + /* we have just sent ABOR and there is no reliable way to check if it was + * successful or not; we have to close the connection now */ + infof(data, "partial download completed, closing connection\n"); + conn->bits.close = TRUE; /* mark for closure */ + return result; + } + if(!ftpc->dont_check) { /* 226 Transfer complete, 250 Requested file action okay, completed. */ if((ftpcode != 226) && (ftpcode != 250)) { -- cgit v1.2.3