From eb60ba23f57eb51aba371c42a5af1e331514a28f Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Mon, 30 Jun 2008 13:07:05 +0000 Subject: - Stephen Collyer and Tor Arntsen helped identify a flaw in the range code which output the range using a signed variable where it should rather use unsigned. --- lib/setup.h | 8 +++++--- lib/url.c | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) (limited to 'lib') diff --git a/lib/setup.h b/lib/setup.h index 38ae32099..1f8505d13 100644 --- a/lib/setup.h +++ b/lib/setup.h @@ -7,7 +7,7 @@ * | (__| |_| | _ <| |___ * \___|\___/|_| \_\_____| * - * Copyright (C) 1998 - 2007, Daniel Stenberg, , et al. + * Copyright (C) 1998 - 2008, Daniel Stenberg, , et al. * * This software is licensed as described in the file COPYING, which * you should have received as part of this distribution. The terms @@ -139,16 +139,18 @@ #ifndef SIZEOF_CURL_OFF_T /* If we don't know the size here, we assume a conservative size: 4. When - building libcurl, the actual size of this variable should be define in the + building libcurl, the actual size of this variable should be defined in the config*.h file. */ #define SIZEOF_CURL_OFF_T 4 #endif -/* We set up our internal prefered (CURL_)FORMAT_OFF_T here */ +/* We set up our internal prefered (CURL_)FORMAT_OFF_T[U] here */ #if SIZEOF_CURL_OFF_T > 4 #define FORMAT_OFF_T "lld" +#define FORMAT_OFF_TU "llu" /* the unsigned version */ #else #define FORMAT_OFF_T "ld" +#define FORMAT_OFF_TU "lu" /* thus unsigned version */ #endif /* SIZEOF_CURL_OFF_T */ #ifndef _REENTRANT diff --git a/lib/url.c b/lib/url.c index e61ec298c..f1f0c3cd7 100644 --- a/lib/url.c +++ b/lib/url.c @@ -3118,7 +3118,7 @@ static CURLcode setup_range(struct SessionHandle *data) free(s->range); if(s->resume_from) - s->range = aprintf("%" FORMAT_OFF_T "-", s->resume_from); + s->range = aprintf("%" FORMAT_OFF_TU "-", s->resume_from); else s->range = strdup(data->set.str[STRING_SET_RANGE]); -- cgit v1.2.3