From 4ff5d32a6b30601b36a39a6bdd3a9c7996303957 Mon Sep 17 00:00:00 2001 From: Steve Holme Date: Thu, 25 Dec 2014 11:23:44 +0000 Subject: tool_xattr: Use 'CURLcode result' for curl result codes --- src/tool_xattr.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) (limited to 'src') diff --git a/src/tool_xattr.c b/src/tool_xattr.c index b2666d973..da0cad67a 100644 --- a/src/tool_xattr.c +++ b/src/tool_xattr.c @@ -5,7 +5,7 @@ * | (__| |_| | _ <| |___ * \___|\___/|_| \_\_____| * - * Copyright (C) 1998 - 2013, Daniel Stenberg, , et al. + * Copyright (C) 1998 - 2014, Daniel Stenberg, , et al. * * This software is licensed as described in the file COPYING, which * you should have received as part of this distribution. The terms @@ -56,11 +56,12 @@ int fwrite_xattr(CURL *curl, int fd) { int i = 0; int err = 0; + /* loop through all xattr-curlinfo pairs and abort on a set error */ while(err == 0 && mappings[i].attr != NULL) { char *value = NULL; - CURLcode rc = curl_easy_getinfo(curl, mappings[i].info, &value); - if(rc == CURLE_OK && value) { + CURLcode result = curl_easy_getinfo(curl, mappings[i].info, &value); + if(!result && value) { #ifdef HAVE_FSETXATTR_6 err = fsetxattr(fd, mappings[i].attr, value, strlen(value), 0, 0); #elif defined(HAVE_FSETXATTR_5) @@ -75,6 +76,7 @@ int fwrite_xattr(CURL *curl, int fd) } i++; } + return err; } #else @@ -82,6 +84,7 @@ int fwrite_xattr(CURL *curl, int fd) { (void)curl; (void)fd; + return 0; } #endif -- cgit v1.2.3