From 80e2b3edb9755ff915185b4fbfa285d482c6bfc6 Mon Sep 17 00:00:00 2001 From: Nick Zitzmann Date: Tue, 19 Feb 2013 19:03:39 -0700 Subject: metalink: fix improbable crash parsing metalink filename The this_url pointer wasn't being initialized, so if strdup() would return null when copying the filename in a metalink file, then hilarity would ensue during the cleanup phase. This change was brought to you by clang, which noticed this and raised a warning. --- src/tool_operate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/tool_operate.c b/src/tool_operate.c index 4166fc2ef..5e73d86d4 100644 --- a/src/tool_operate.c +++ b/src/tool_operate.c @@ -535,7 +535,7 @@ int operate(struct Configurable *config, int argc, argv_item_t argv[]) long retry_numretries; long retry_sleep_default; long retry_sleep; - char *this_url; + char *this_url = NULL; int metalink_next_res = 0; outfile = NULL; -- cgit v1.2.3