From d8efde07e556c42ee35ddc0bcc6daf4d13c948a9 Mon Sep 17 00:00:00 2001 From: Marc Hoersken Date: Sun, 14 Dec 2014 22:45:06 +0100 Subject: tool_urlglob.c: Silence warning C6293: Ill-defined for-loop The >= 0 is actually not required, since i underflows and the for-loop is stopped using the < condition, but this makes the VS2012 compiler and code analysis happy. --- src/tool_urlglob.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/tool_urlglob.c b/src/tool_urlglob.c index 36e83c330..9dace458d 100644 --- a/src/tool_urlglob.c +++ b/src/tool_urlglob.c @@ -466,7 +466,7 @@ void glob_cleanup(URLGlob* glob) int elem; /* the < condition is required since i underflows! */ - for(i = glob->size - 1; i < glob->size; --i) { + for(i = glob->size - 1; i >= 0 && i < glob->size; --i) { if((glob->pattern[i].type == UPTSet) && (glob->pattern[i].content.Set.elements)) { for(elem = glob->pattern[i].content.Set.size - 1; @@ -500,7 +500,7 @@ int glob_next_url(char **globbed, URLGlob *glob) /* implement a counter over the index ranges of all patterns, starting with the rightmost pattern */ /* the < condition is required since i underflows! */ - for(i = glob->size - 1; carry && (i < glob->size); --i) { + for(i = glob->size - 1; carry && i >= 0 && (i < glob->size); --i) { carry = FALSE; pat = &glob->pattern[i]; switch (pat->type) { -- cgit v1.2.3