From eb433389411f778ed8e6b516a5b8fa35d57564ef Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Tue, 26 Feb 2019 16:35:07 +0100 Subject: cookies: only save the cookie file if the engine is enabled Follow-up to 8eddb8f4259. If the cookieinfo pointer is NULL there really is nothing to save. Without this fix, we got a problem when a handle was using shared object with cookies and is told to "FLUSH" it to file (which worked) and then the share object was removed and when the easy handle was closed just afterwards it has no cookieinfo and no cookies so it decided to save an empty jar (overwriting the file just flushed). Test 1905 now verifies that this works. Assisted-by: Michael Wallner Assisted-by: Marcel Raad Closes #3621 --- tests/data/test1905 | 60 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 60 insertions(+) create mode 100644 tests/data/test1905 (limited to 'tests/data/test1905') diff --git a/tests/data/test1905 b/tests/data/test1905 new file mode 100644 index 000000000..dac1471f5 --- /dev/null +++ b/tests/data/test1905 @@ -0,0 +1,60 @@ + + + +HTTP +cookies +FLUSH + + + +# Server-side + + +HTTP/1.1 200 OK +Date: Thu, 09 Nov 2010 14:49:00 GMT +Server: test-server/fake +Content-Type: text/html +Funny-head: yesyes swsclose +Set-Cookie: foobar=name; +Set-Cookie: secondcookie=present; + + + + +# Client-side + + +http + + +CURLOPT_COOKIELIST set to "FLUSH" of a shared cookie object + + +lib1905 + +http://%HOSTIP:%HTTPPORT/we/want/1905 + + + +# Verify data after the test has been "shot" + + +^User-Agent:.* + + +GET /we/want/1905 HTTP/1.1 +Host: %HOSTIP:%HTTPPORT +Accept: */* + + + +# Netscape HTTP Cookie File +# https://curl.haxx.se/docs/http-cookies.html +# This file was generated by libcurl! Edit at your own risk. + +%HOSTIP FALSE /we/want/ FALSE 0 secondcookie present +%HOSTIP FALSE /we/want/ FALSE 0 foobar name + + + -- cgit v1.2.3