From fa0ac3f4d9ca095c33bca62ba2f64c95e3c3456a Mon Sep 17 00:00:00 2001 From: Dan Fandrich Date: Sat, 13 May 2017 19:04:10 +0200 Subject: tests: made a couple of prechecks consistent with others Also removed a TODO suggesting caching the precheck results. Tests showed this would save about 0.1 sec on the total test run time on a relatively modern system, an unnoticeable gain at the cost of longer and more complicated code. There would also be a danger that a cached test result would be inappropriately returned, such as when other test dependencies (like environment variables) are different or when the precheck causes side effects (like filesystem changes). --- tests/data/test31 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tests/data/test31') diff --git a/tests/data/test31 b/tests/data/test31 index 2289d56d7..54e360a46 100644 --- a/tests/data/test31 +++ b/tests/data/test31 @@ -80,7 +80,7 @@ TZ=GMT http://%HOSTIP:%HTTPPORT/we/want/31 -b none -c log/jar31.txt -perl -e 'if ("%HOSTIP" !~ /127\.0\.0\.1$/) {print "Test only works for HOSTIP 127.0.0.1"; exit(1)}' +perl -e "print 'Test requires default test server host' if ( '%HOSTIP' ne '127.0.0.1' );" -- cgit v1.2.3