From 0ddc678927eaa127efc457535858c19e791a5339 Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Sun, 4 Aug 2013 23:27:27 +0200 Subject: formadd: wrong pointer for file name when CURLFORM_BUFFERPTR used The internal function that's used to detect known file extensions for the default Content-Type got the the wrong pointer passed in when CURLFORM_BUFFER + CURLFORM_BUFFERPTR were used. This had the effect that strlen() would be used which could lead to an out-of-bounds read (and thus segfault). In most cases it would only lead to it not finding or using the correct default content-type. It also showed that test 554 and test 587 were testing for the previous/wrong behavior and now they're updated as well. Bug: http://curl.haxx.se/bug/view.cgi?id=1262 Reported-by: Konstantin Isakov --- tests/data/test587 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tests/data/test587') diff --git a/tests/data/test587 b/tests/data/test587 index d936372c5..e73cc2cf7 100644 --- a/tests/data/test587 +++ b/tests/data/test587 @@ -35,7 +35,7 @@ s/boundary=------------------------[a-z0-9]*/boundary=-------------------------- POST /587 HTTP/1.1 Host: %HOSTIP:%HTTPPORT Accept: */* -Content-Length: 732 +Content-Length: 718 Expect: 100-continue Content-Type: multipart/form-data; boundary=---------------------------- -- cgit v1.2.3