From 0523152ad6e9d558c31bf176e8103038430badb3 Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Fri, 26 Apr 2013 16:45:31 +0200 Subject: ftp_state_pasv_resp: connect through proxy also when set by env When connecting back to an FTP server after having sent PASV/EPSV, libcurl sometimes didn't use the proxy properly even though the proxy was used for the initial connect. The function wrongly checked for the CURLOPT_PROXY variable to be set, which made it act wrongly if the proxy information was set with an environment variable. Added test case 711 to verify (based on 707 which uses --socks5). Also added test712 to verify another variation of setting the proxy: with --proxy socks5:// Bug: http://curl.haxx.se/bug/view.cgi?id=1218 Reported-by: Zekun Ni --- tests/data/test712 | 49 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 tests/data/test712 (limited to 'tests/data/test712') diff --git a/tests/data/test712 b/tests/data/test712 new file mode 100644 index 000000000..c62e9f2c5 --- /dev/null +++ b/tests/data/test712 @@ -0,0 +1,49 @@ + +#based off test 707 after bug report #1218 + + +FTP +PASV +RETR +SOCKS5 +all_proxy + + +# +# Server-side + + +silly content + + + +# +# Client-side + + +ftp +socks5 + + +FTP fetch with --proxy set to socks5:// + + +ftp://%HOSTIP:%FTPPORT/712 --proxy socks5://%HOSTIP:%SOCKSPORT + + + +# +# Verify data after the test has been "shot" + + +USER anonymous +PASS ftp@example.com +PWD +EPSV +TYPE I +SIZE 712 +RETR 712 +QUIT + + + -- cgit v1.2.3