From 67bf4f28ffcd7102602a83343da8df8058f9af4f Mon Sep 17 00:00:00 2001
From: Daniel Stenberg <daniel@haxx.se>
Date: Tue, 24 Jan 2006 14:40:43 +0000
Subject: Michal Marek provided a patch for FTP that makes libcurl continue to
 try PASV even after EPSV returned a positive response code, if libcurl failed
 to connect to the port number the EPSV response said. Obviously some people
 are going through protocol-sensitive firewalls (or similar) that don't
 understand EPSV and then they don't allow the second connection unless PASV
 was used. This also called for a minor fix of test case 238.

---
 tests/data/test238 | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

(limited to 'tests/data')

diff --git a/tests/data/test238 b/tests/data/test238
index c314f6b7c..8e23b4fb0 100644
--- a/tests/data/test238
+++ b/tests/data/test238
@@ -8,26 +8,32 @@
 ftp
 </server>
  <name>
-FTP getting bad port in 229-response to EPSV
+FTP getting bad port in response to EPSV and in response to PASV
  </name>
  <command>
 ftp://%HOSTIP:%FTPPORT/238
 </command>
 <file name="log/ftpserver.cmd">
 REPLY EPSV 229 Entering Passiv Mode (|||1000000|)
+REPLY PASV 227 Entering Passiv Mode (1216,256,2,127,127,127)
 </file>
 </client>
 
 # Verify data after the test has been "shot"
 <verify>
-# 7 => CURLE_COULDNT_CONNECT
+# curl: (15) Can't resolve new host 1216.256.2.127:32639
+# 15 => CURLE_FTP_CANT_GET_HOST
+# some systems just don't fail on the illegal host name/address but instead
+# moves on and attempt to connect to... yes, to what?
+# 7= CURLE_COULDNT_CONNECT
 <errorcode>
-7
+7, 15
 </errorcode>
 <protocol>
 USER anonymous
 PASS curl_by_daniel@haxx.se
 PWD
 EPSV
+PASV
 </protocol>
 </verify>
-- 
cgit v1.2.3