From 29c655c0a6affc0359e499162e8308663eb4d04f Mon Sep 17 00:00:00 2001 From: Markus Elfring Date: Wed, 11 Mar 2015 17:41:01 +0100 Subject: Bug #149: Deletion of unnecessary checks before calls of the function "free" The function "free" is documented in the way that no action shall occur for a passed null pointer. It is therefore not needed that a function caller repeats a corresponding check. http://stackoverflow.com/questions/18775608/free-a-null-pointer-anyway-or-check-first This issue was fixed by using the software Coccinelle 1.0.0-rc24. Signed-off-by: Markus Elfring --- tests/server/tftpd.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'tests/server/tftpd.c') diff --git a/tests/server/tftpd.c b/tests/server/tftpd.c index 25557932f..cef129f2e 100644 --- a/tests/server/tftpd.c +++ b/tests/server/tftpd.c @@ -876,8 +876,7 @@ int main(int argc, char **argv) memset(&test, 0, sizeof(test)); if (do_tftp(&test, tp, n) < 0) break; - if(test.buffer) - free(test.buffer); + free(test.buffer); } sclose(peer); peer = CURL_SOCKET_BAD; @@ -1089,8 +1088,7 @@ static int parse_servercmd(struct testcase *req) else break; } - if(orgcmd) - free(orgcmd); + free(orgcmd); } return 0; /* OK! */ -- cgit v1.2.3