From 2aff76c571e72d78af690e5fd6ba11642fb06f14 Mon Sep 17 00:00:00 2001 From: Stephan Szabo Date: Wed, 19 Jun 2019 15:54:18 -0700 Subject: tests: support non-localhost HOSTIP for dict/smb servers smbserver.py/dictserver.py were explicitly using localhost/127.0.0.1 for binding the server which when we were running the tests with a separate HOSTIP and CLIENTIP had failures verifying the server from the device we were testing. This changes them to take the address from runtests.py and default to localhost/127.0.0.1 if none is given. Closes #4048 --- tests/smbserver.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'tests/smbserver.py') diff --git a/tests/smbserver.py b/tests/smbserver.py index 195ae395b..474e0612b 100755 --- a/tests/smbserver.py +++ b/tests/smbserver.py @@ -86,7 +86,7 @@ def smbserver(options): test_data_dir = os.path.join(options.srcdir, "data") - smb_server = TestSmbServer(("127.0.0.1", options.port), + smb_server = TestSmbServer((options.host, options.port), config_parser=smb_config, test_data_directory=test_data_dir) log.info("[SMB] setting up SMB server on port %s", options.port) @@ -312,6 +312,8 @@ def get_options(): parser.add_argument("--port", action="store", default=9017, type=int, help="port to listen on") + parser.add_argument("--host", action="store", default="127.0.0.1", + help="host to listen on") parser.add_argument("--verbose", action="store", type=int, default=0, help="verbose output") parser.add_argument("--pidfile", action="store", -- cgit v1.2.3