From 37201e3c36541a1a7f14424860e1f685eaa83e7c Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Tue, 10 Aug 2010 15:28:46 +0200 Subject: callbacks: acknowledge progress callback error returns When the progress callback is called during the TCP connection, an error return would accidentally not abort the operation as intended but would instead be counted as a failure to connect to that particular IP and libcurl would just continue to try the next. I made singleipconnect() and trynextip() return CURLcode properly. Added bonus: it corrected the error code for bad --interface usages, like tested in test 1084 and test 1085. Reported by: Adam Light Bug: http://curl.haxx.se/mail/lib-2010-08/0105.html --- tests/data/test1084 | 2 +- tests/data/test1085 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'tests') diff --git a/tests/data/test1084 b/tests/data/test1084 index 2bc0183a7..1cfab68dc 100644 --- a/tests/data/test1084 +++ b/tests/data/test1084 @@ -35,7 +35,7 @@ http://%HOSTIP:%HTTPPORT/1084 --interface non-existing-host.haxx.se. # Verify data after the test has been "shot" -7 +45 diff --git a/tests/data/test1085 b/tests/data/test1085 index 0cedefe3b..db02e6033 100644 --- a/tests/data/test1085 +++ b/tests/data/test1085 @@ -42,7 +42,7 @@ HTTP-IPv6 GET with invalid --interface # Verify data after the test has been "shot" -7 +45 -- cgit v1.2.3