diff options
author | Niall Sheridan <nsheridan@gmail.com> | 2018-08-08 11:24:22 +0100 |
---|---|---|
committer | Niall Sheridan <nsheridan@gmail.com> | 2018-08-08 12:49:47 +0100 |
commit | 12417f0dddf4be86aa5b9a4cb25bf48a4e301086 (patch) | |
tree | 280653d0ecefbbb22d9574221b64b079953a8c4b /server/store/sqldb.go | |
parent | 60d005f8d174d21162cab2b029f74cfe2925acab (diff) |
Misc fixes
- Add `fast_finish` to travis config
- Specify that Go 1.9 is supported
- Additional error checking which was previously missed
- Make the migrations test better
-
Diffstat (limited to 'server/store/sqldb.go')
-rw-r--r-- | server/store/sqldb.go | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/server/store/sqldb.go b/server/store/sqldb.go index b5948b7..e95f53b 100644 --- a/server/store/sqldb.go +++ b/server/store/sqldb.go @@ -108,11 +108,6 @@ func autoMigrate(driver string, conn *sqlx.DB) error { return nil } -// rowScanner is implemented by sql.Row and sql.Rows -type rowScanner interface { - Scan(dest ...interface{}) error -} - // Get a single *CertRecord func (db *sqlStore) Get(id string) (*CertRecord, error) { if err := db.conn.Ping(); err != nil { @@ -161,6 +156,10 @@ func (db *sqlStore) Revoke(ids []string) error { return errors.Wrap(err, "unable to connect to database") } q, args, err := sqlx.In("UPDATE issued_certs SET revoked = 1 WHERE key_id IN (?)", ids) + if err != nil { + return err + } + q = db.conn.Rebind(q) _, err = db.conn.Query(q, args...) return err } |