diff options
author | Daniel Stenberg <daniel@haxx.se> | 2014-12-21 23:21:16 +0100 |
---|---|---|
committer | Daniel Stenberg <daniel@haxx.se> | 2014-12-21 23:21:16 +0100 |
commit | 2c5f346d3a18b829f2c9ce8dbb98470e41017ca3 (patch) | |
tree | b0004308f6dce1315e465f2b692dcec6e32262b9 | |
parent | f9cf3de70b3a494f627eda6cccf6607616eaf449 (diff) |
smb: use memcpy() instead of strncpy()
... as it never copies the trailing zero anyway and always just the four
bytes so let's not mislead anyone into thinking it is actually treated
as a string.
Coverity CID: 1260214
-rw-r--r-- | lib/smb.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -345,7 +345,7 @@ static void smb_format_message(struct connectdata *conn, struct smb_header *h, memset(h, 0, sizeof(*h)); h->nbt_length = htons((unsigned short) (sizeof(*h) - sizeof(unsigned int) + len)); - strncpy((char *)h->magic, "\xffSMB", 4); + memcpy((char *)h->magic, "\xffSMB", 4); h->command = cmd; h->flags = SMB_FLAGS_CANONICAL_PATHNAMES | SMB_FLAGS_CASELESS_PATHNAMES; h->flags2 = smb_swap16(SMB_FLAGS2_IS_LONG_NAME | SMB_FLAGS2_KNOWS_LONG_NAME); |