aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Stenberg <daniel@haxx.se>2015-03-14 18:17:59 +0100
committerDaniel Stenberg <daniel@haxx.se>2015-03-14 18:19:51 +0100
commit0cf649d9cc550af0ef5c9577d38c800be167f373 (patch)
tree4a3ce022918cc72197aa2974c548111e7ba251b7
parent0911b963995b792ccd207baa8741785315d768eb (diff)
http2: detect prematures close without data transfered
... by using the regular Curl_http_done() method which checks for that. This makes test 1801 fail consistently with error 56 (which seems fine) to that test is also updated here. Reported-by: Ben Darnell Bug: https://github.com/bagder/curl/issues/166
-rw-r--r--lib/http2.c4
-rw-r--r--tests/data/test18014
2 files changed, 6 insertions, 2 deletions
diff --git a/lib/http2.c b/lib/http2.c
index 89bc57d5e..ea20b0a11 100644
--- a/lib/http2.c
+++ b/lib/http2.c
@@ -102,7 +102,7 @@ const struct Curl_handler Curl_handler_http2 = {
"HTTP2", /* scheme */
ZERO_NULL, /* setup_connection */
Curl_http, /* do_it */
- ZERO_NULL, /* done */
+ Curl_http_done, /* done */
ZERO_NULL, /* do_more */
ZERO_NULL, /* connect_it */
ZERO_NULL, /* connecting */
@@ -122,7 +122,7 @@ const struct Curl_handler Curl_handler_http2_ssl = {
"HTTP2", /* scheme */
ZERO_NULL, /* setup_connection */
Curl_http, /* do_it */
- ZERO_NULL, /* done */
+ Curl_http_done, /* done */
ZERO_NULL, /* do_more */
ZERO_NULL, /* connect_it */
ZERO_NULL, /* connecting */
diff --git a/tests/data/test1801 b/tests/data/test1801
index 3e069f585..a95e76a22 100644
--- a/tests/data/test1801
+++ b/tests/data/test1801
@@ -62,5 +62,9 @@ Upgrade: %H2CVER
HTTP2-Settings: AAMAAABkAAQAAP__
</protocol>
+# nothing is returned, because no HTTP/2 data nor headers was handled
+<errorcode>
+56
+</errorcode>
</verify>
</testcase>