diff options
| author | Daniel Stenberg <daniel@haxx.se> | 2006-08-31 12:53:39 +0000 | 
|---|---|---|
| committer | Daniel Stenberg <daniel@haxx.se> | 2006-08-31 12:53:39 +0000 | 
| commit | d7168a82e2123b6c3eb4db8e890ce7c14e21b32a (patch) | |
| tree | d54f793ce363d67cff2cae2dd5f2d9270d38a57f | |
| parent | c9c8ee3796dc2ab71a04c9b5bfb23dd98b47ddf5 (diff) | |
Dmitriy Sergeyev found and fixed a multi interface flaw when using asynch
name resolves. It could get stuck in the wrong state.
| -rw-r--r-- | CHANGES | 4 | ||||
| -rw-r--r-- | RELEASE-NOTES | 5 | ||||
| -rw-r--r-- | lib/multi.c | 8 | 
3 files changed, 14 insertions, 3 deletions
@@ -7,6 +7,10 @@                                    Changelog +Daniel (31 August 2006) +- Dmitriy Sergeyev found and fixed a multi interface flaw when using asynch +  name resolves. It could get stuck in the wrong state. +  Gisle (29 August 2006)  - Added support for other MS-DOS compilers (desides djgpp). All MS-DOS    compiler now uses the same config.dos file (renamed to config.h by diff --git a/RELEASE-NOTES b/RELEASE-NOTES index 70689cee6..05fe3b190 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -11,12 +11,14 @@ Curl and libcurl 7.15.6  This release includes the following changes: + o Added support for other MS-DOS compilers (desides djgpp)   o CURLOPT_SOCKOPTFUNCTION and CURLOPT_SOCKOPTDATA were added   o (FTP) libcurl avoids sending TYPE if the desired type was already set   o (FTP) CURLOPT_PREQUOTE works even when CURLOPT_NOBODY is set true  This release includes the following bugfixes: + o multi interface using asynch resolves could get stuck in wrong state   o the 'running_handles' counter wasn't always updated properly when     curl_multi_remove_handle() was used   o (FTP) EPRT transfers with IPv6 didn't work properly @@ -31,12 +33,13 @@ Other curl-related news:  New curl mirrors: + o http://curl.geosdreams.info/ is a new Polish mirror   o http://curl.gfiles.org/ is a new Russian mirror  This release would not have looked like this without help, code, reports and  advice from friends like these:   Domenico Andreoli, Armel Asselin, Gisle Vanem, Yang Tse, Andrew Biggs, - Peter Sylvester, David McCreedy + Peter Sylvester, David McCreedy, Dmitriy Sergeyev          Thanks! (and sorry if I forgot to mention someone) diff --git a/lib/multi.c b/lib/multi.c index c1ff12e29..01891b5dd 100644 --- a/lib/multi.c +++ b/lib/multi.c @@ -639,8 +639,12 @@ static CURLMcode multi_runsingle(struct Curl_multi *multi,               is already freed and gone */            easy->easy_conn = NULL;           /* no more connection */          else { -          /* FIX: what if protocol_connect is TRUE here?! */ -          multistate(easy, CURLM_STATE_WAITCONNECT); +          /* call again please so that we get the next socket setup */ +          result = CURLM_CALL_MULTI_PERFORM; +          if(protocol_connect) +            multistate(easy, CURLM_STATE_DO); +          else +            multistate(easy, CURLM_STATE_WAITCONNECT);          }        }  | 
