aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Stenberg <daniel@haxx.se>2014-10-07 10:29:06 +0200
committerDaniel Stenberg <daniel@haxx.se>2014-10-07 10:29:06 +0200
commitdddb2aab8d8961fe1483258bd64cbf43b972ce0a (patch)
treea63d0dde4c7ae1e61c8f1b3910e328d89379634e
parentb7d3338df2843a064747d8928b0a9e8a2200e38d (diff)
parseconfig: skip a NULL check
Coverity CID 1154198. This NULL check implies that the pointer _can_ be NULL at this point, which it can't. Thus it is dead code. It tricks static analyzers to warn about dereferencing the pointer since the code seems to imply it can be NULL.
-rw-r--r--src/tool_parsecfg.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/tool_parsecfg.c b/src/tool_parsecfg.c
index 7a161c3bb..c5d390b7a 100644
--- a/src/tool_parsecfg.c
+++ b/src/tool_parsecfg.c
@@ -208,7 +208,7 @@ int parseconfig(const char *filename, struct GlobalConfig *global)
}
}
- if(param && !*param) {
+ if(!*param) {
/* do this so getparameter can check for required parameters.
Otherwise it always thinks there's a parameter. */
if(alloced_param)