aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIsaac Boukris <iboukris@gmail.com>2016-04-16 11:49:09 +0300
committerDaniel Stenberg <daniel@haxx.se>2016-04-20 15:26:45 +0200
commitfa5fa65a309f352284e58f52183d586886eb17ea (patch)
treee5320a59c848f288d51b12b9a5f11758184628c9
parent4fbd57693054eb14499cde2ace2dc7890800598b (diff)
NTLM: check for NULL pointer before deferencing
At ConnectionExists, both check->proxyuser and check->proxypasswd could be NULL, so make sure to check first. Fixes #765
-rw-r--r--lib/url.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/lib/url.c b/lib/url.c
index 184e27049..b50ca8677 100644
--- a/lib/url.c
+++ b/lib/url.c
@@ -3444,6 +3444,10 @@ ConnectionExists(struct SessionHandle *data,
/* Same for Proxy NTLM authentication */
if(wantProxyNTLMhttp) {
+ /* Both check->proxyuser and check->proxypasswd could be NULL */
+ if(check->proxyuser == NULL || check->proxypasswd == NULL)
+ continue;
+
if(!strequal(needle->proxyuser, check->proxyuser) ||
!strequal(needle->proxypasswd, check->proxypasswd))
continue;