diff options
| author | Daniel Stenberg <daniel@haxx.se> | 2010-03-23 13:18:30 +0100 |
|---|---|---|
| committer | Daniel Stenberg <daniel@haxx.se> | 2010-03-23 13:18:30 +0100 |
| commit | 2a94293efd3896eca067c4b53ccfdf362a042db2 (patch) | |
| tree | 5381a0efea8bb9dd925e5c859ac4bc2f3666d35a /CHANGES | |
| parent | b33ddd615aad0459a9022b1c932e1831a0dbc965 (diff) | |
delayed easy handle kill caused double Curl_close() call
Hauke Duden provided an example program that made the multi
interface crash. His example simply used the multi interface and
did first one FTP transfer and after completion it used a second
easy handle and did another FTP transfer on the same FTP server.
This triggered a bug in the "delayed easy handle kill" system
that curl uses: when an FTP connection is left alive it must keep
an easy handle around internally - only for the purpose of having
an easy handle when it later disconnects it. The code assumed
that when the easy handle was removed and an internal reference
was made, that version could be killed later on when a new easy
handle came using the same connection. This was wrong as Hauke's
example showed that the removed handle wasn't killed for real
until later. This caused a double close attempt => segfault.
Diffstat (limited to 'CHANGES')
| -rw-r--r-- | CHANGES | 15 |
1 files changed, 15 insertions, 0 deletions
@@ -6,6 +6,21 @@ Changelog +Daniel Stenberg (23 Mar 2010) +- Hauke Duden provided an example program that made the multi interface crash. + His example simply used the multi interface and did first one FTP transfer + and after completion it used a second easy handle and did another FTP + transfer on the same FTP server. + + This triggered a bug in the "delayed easy handle kill" system that curl + uses: when an FTP connection is left alive it must keep an easy handle + around internally - only for the purpose of having an easy handle when it + later disconnects it. The code assumed that when the easy handle was removed + and an internal reference was made, that version could be killed later on + when a new easy handle came using the same connection. This was wrong as + Hauke's example showed that the removed handle wasn't killed for real until + later. This caused a double close attempt => segfault. + Daniel Stenberg (22 Mar 2010) - Thomas Lopatic fixed the alarm()-based DNS timeout: |