diff options
| author | Daniel Stenberg <daniel@haxx.se> | 2005-06-02 11:09:10 +0000 |
|---|---|---|
| committer | Daniel Stenberg <daniel@haxx.se> | 2005-06-02 11:09:10 +0000 |
| commit | 050bd7dd0bb089f24325db241a942d1a39559b5d (patch) | |
| tree | fba85414b332241992c2be755800f7e21a35e1a6 /ares/CHANGES | |
| parent | f75038634f1bc8aa6e7818ace0428d5aa3cc32d4 (diff) | |
William Ahern:
I'm not quite sure how this was happening, but I've been seeing PTR queries
which seem to return empty responses. At least, they were empty when calling
ares_expand_name() on the record. Here's a patch which guarantees to
NUL-terminate the expanded name. The old behavior failed to NUL-terminate if
len was 0, and this was causing strlen() to run past the end of the buffer
after calling ares_expand_name() and getting ARES_SUCCESS as the return
value. If q is not greater than *s then it's equal and *s is always
allocated with at least one byte.
Diffstat (limited to 'ares/CHANGES')
| -rw-r--r-- | ares/CHANGES | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/ares/CHANGES b/ares/CHANGES index 858804065..cb1fdac24 100644 --- a/ares/CHANGES +++ b/ares/CHANGES @@ -1,5 +1,19 @@ Changelog for the c-ares project +* June 2 + +- William Ahern: + + I'm not quite sure how this was happening, but I've been seeing PTR queries + which seem to return empty responses. At least, they were empty when calling + ares_expand_name() on the record. Here's a patch which guarantees to + NUL-terminate the expanded name. The old behavior failed to NUL-terminate if + len was 0, and this was causing strlen() to run past the end of the buffer + after calling ares_expand_name() and getting ARES_SUCCESS as the return + value. If q is not greater than *s then it's equal and *s is always + allocated with at least one byte. + + * May 16 - Added ares_getnameinfo which mimics the getnameinfo API (another feature |