aboutsummaryrefslogtreecommitdiff
path: root/ares/ares_getsock.c
diff options
context:
space:
mode:
authorSteinar H. Gunderson <sesse@google.com>2007-09-29 18:18:47 +0000
committerSteinar H. Gunderson <sesse@google.com>2007-09-29 18:18:47 +0000
commit23f5d145ec69e2a8b62e75cc49b591fef04ca48d (patch)
tree3bbbeb0269bb896342bc24b839d7b5ac966bf6f7 /ares/ares_getsock.c
parentb01ab65225dec292919f8123ef2557d0a94e4569 (diff)
Previously, processing a large batch of timeouts was O(n^2) in the number of
outstanding queries, and processing a DNS response packet was O(n) in the number of outstanding queries. To speed things up in Google, we added a few circular, doubly-linked lists of queries that are hash-bucketed based on the attributes we care about, so most important operations are now O(1). It might be that the number of buckets are higher than most people would need, but on a quick calculation it should only be 100kB or so even on a 64-bit system, so I've let it stay as-is.
Diffstat (limited to 'ares/ares_getsock.c')
-rw-r--r--ares/ares_getsock.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/ares/ares_getsock.c b/ares/ares_getsock.c
index 01df5d564..99419aee2 100644
--- a/ares/ares_getsock.c
+++ b/ares/ares_getsock.c
@@ -35,7 +35,7 @@ int ares_getsock(ares_channel channel,
ares_socket_t *socks = (ares_socket_t *)s;
/* No queries, no file descriptors. */
- if (!channel->queries)
+ if (ares__is_list_empty(&(channel->all_queries)))
return 0;
for (i = 0;