diff options
| author | Daniel Stenberg <daniel@haxx.se> | 2007-03-25 08:41:22 +0000 |
|---|---|---|
| committer | Daniel Stenberg <daniel@haxx.se> | 2007-03-25 08:41:22 +0000 |
| commit | 52e5e869e60a15df0756af7bae5a6a452db59aa1 (patch) | |
| tree | 5a85c780451272a8017013f185d0a9b846dd2e86 /docs/CONTRIBUTE | |
| parent | 12ef1035bbc491a4924fcc842360fd38feaa460a (diff) | |
Added the How to get your patches into the libcurl sources instruction posted
recently
Diffstat (limited to 'docs/CONTRIBUTE')
| -rw-r--r-- | docs/CONTRIBUTE | 29 |
1 files changed, 25 insertions, 4 deletions
diff --git a/docs/CONTRIBUTE b/docs/CONTRIBUTE index a14d1aa82..5d9675940 100644 --- a/docs/CONTRIBUTE +++ b/docs/CONTRIBUTE @@ -17,7 +17,9 @@ Join the Community you start sending patches! We prefer patches and discussions being held on the mailing list(s), not sent to individuals. -The License Issue + We also hang out on IRC in #curl on irc.freenode.net + +License When contributing with code, you agree to put your changes and new code under the same license curl and libcurl is already using unless stated and agreed @@ -43,9 +45,10 @@ The License Issue What To Read - Source code, the man pages, the INTERNALS document, the TODO, the most recent - CHANGES. Just lurking on the libcurl mailing list is gonna give you a lot of - insights on what's going on right now. Asking there is a good idea too. + Source code, the man pages, the INTERNALS document, TODO, KNOWN_BUGS, the + most recent CHANGES. Just lurking on the libcurl mailing list is gonna give + you a lot of insights on what's going on right now. Asking there is a good + idea too. Naming @@ -170,3 +173,21 @@ How To Make a Patch http://gnuwin32.sourceforge.net/packages/patch.htm http://gnuwin32.sourceforge.net/packages/diffutils.htm + +How to get your patches into the libcurl sources + + 1. Submit your patch to the curl-library mailing list + + 2. Make the patch against as recent sources as possible. + + 3. Make sure your patch adheres to the source indent and coding style of + already existing source code. Failing to do so just adds more work for me. + + 4. Respond to replies on the list about the patch and answer questions and/or + fix nits/flaws. This is very important. I will take lack of replies as a + sign that you're not very anxious to get your patch accepted and I tend to + simply drop such patches from my TODO list. + + 5. If you've followed the above mentioned paragraphs and your patch still + hasn't been incorporated after some weeks, consider resubmitting them to + the list. |