diff options
| author | Patrick Monnerat <patrick@monnerat.net> | 2018-01-14 19:43:12 +0100 |
|---|---|---|
| committer | Patrick Monnerat <patrick@monnerat.net> | 2018-01-14 19:43:12 +0100 |
| commit | e44ddfd477bdf3fa37438722055afa3aa4e5f8a3 (patch) | |
| tree | e222ef75b1e8a6ca13813145c855fd6b2d450461 /docs/libcurl | |
| parent | 2c821bba853a739ce4c311a4e8b4a33e75128dd2 (diff) | |
mime: clone mime tree upon easy handle duplication.
A mime tree attached to an easy handle using CURLOPT_MIMEPOST is
strongly bound to the handle: there is a pointer to the easy handle in
each item of the mime tree and following the parent pointer list
of mime items ends in a dummy part stored within the handle.
Because of this binding, a mime tree cannot be shared between different
easy handles, thus it needs to be cloned upon easy handle duplication.
There is no way for the caller to get the duplicated mime tree
handle: it is then set to be automatically destroyed upon freeing the
new easy handle.
New test 654 checks proper mime structure duplication/release.
Add a warning note in curl_mime_data_cb() documentation about sharing
user data between duplicated handles.
Closes #2235
Diffstat (limited to 'docs/libcurl')
| -rw-r--r-- | docs/libcurl/curl_mime_data_cb.3 | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/docs/libcurl/curl_mime_data_cb.3 b/docs/libcurl/curl_mime_data_cb.3 index f8421d5da..105968a0e 100644 --- a/docs/libcurl/curl_mime_data_cb.3 +++ b/docs/libcurl/curl_mime_data_cb.3 @@ -5,7 +5,7 @@ .\" * | (__| |_| | _ <| |___ .\" * \___|\___/|_| \_\_____| .\" * -.\" * Copyright (C) 1998 - 2017, Daniel Stenberg, <daniel@haxx.se>, et al. +.\" * Copyright (C) 1998 - 2018, Daniel Stenberg, <daniel@haxx.se>, et al. .\" * .\" * This software is licensed as described in the file COPYING, which .\" * you should have received as part of this distribution. The terms @@ -91,6 +91,12 @@ The callback function must return \fICURL_SEEKFUNC_OK\fP on success, is free to work around the problem if possible. The latter can sometimes be done by instead reading from the input or similar. +Care must be taken if the part is bound to a curl easy handle that is later +duplicated: the \fIarg\fP pointer argument is also duplicated, resulting in +the pointed item to be shared between the original and the copied handle. +In particular, special attention should be given to the \fIfreefunc\fP +procedure code since it will be called twice with the same argument. + .SH AVAILABILITY As long as at least one of HTTP, SMTP or IMAP is enabled. Added in 7.56.0. .SH RETURN VALUE @@ -157,4 +163,5 @@ int seek_callback(void *arg, curl_off_t offset, int origin) .SH "SEE ALSO" .BR curl_mime_addpart "(3)," .BR curl_mime_data "(3)," -.BR curl_mime_name "(3)" +.BR curl_mime_name "(3)," +.BR curl_easy_duphandle "(3)" |