diff options
author | Daniel Stenberg <daniel@haxx.se> | 2015-11-24 09:32:42 +0100 |
---|---|---|
committer | Daniel Stenberg <daniel@haxx.se> | 2015-11-24 09:36:45 +0100 |
commit | c341311a0e875f4fc5229721c2f6ef19414f514e (patch) | |
tree | 910cbae630ca12c3e9da147c31d667425a0337eb /lib/http.c | |
parent | fc5d783589268b7ee66a80173c48e940015b1787 (diff) |
Revert "cleanup: general removal of TODO (and similar) comments"
This reverts commit 64e959ffe37c436503f9fed1ce2d6ee6ae50bd9a.
Feedback-by: Dan Fandrich
URL: http://curl.haxx.se/mail/lib-2015-11/0062.html
Diffstat (limited to 'lib/http.c')
-rw-r--r-- | lib/http.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/lib/http.c b/lib/http.c index eaa5f949c..0ed9c9844 100644 --- a/lib/http.c +++ b/lib/http.c @@ -2047,7 +2047,10 @@ CURLcode Curl_http(struct connectdata *conn, bool *done) ptr = strstr(url, conn->host.dispname); if(ptr) { /* This is where the display name starts in the URL, now replace this - part with the encoded name. */ + part with the encoded name. TODO: This method of replacing the host + name is rather crude as I believe there's a slight risk that the + user has entered a user name or password that contain the host name + string. */ size_t currlen = strlen(conn->host.dispname); size_t newlen = strlen(conn->host.name); size_t urllen = strlen(url); @@ -3329,6 +3332,7 @@ CURLcode Curl_http_readwrite_headers(struct SessionHandle *data, conn->httpversion = 11; /* For us, RTSP acts like HTTP 1.1 */ } else { + /* TODO: do we care about the other cases here? */ nc = 0; } } @@ -3559,6 +3563,7 @@ CURLcode Curl_http_readwrite_headers(struct SessionHandle *data, } if(k->auto_decoding) + /* TODO: we only support the first mentioned compression for now */ break; if(checkprefix("identity", start)) { |