diff options
| author | Marcel Raad <Marcel.Raad@teamviewer.com> | 2019-05-25 10:06:08 +0200 |
|---|---|---|
| committer | Marcel Raad <Marcel.Raad@teamviewer.com> | 2019-06-05 20:38:06 +0200 |
| commit | e23c52b3295a525fbaae9e7ed3e7061fea6dffc2 (patch) | |
| tree | 4a74cf5ed3496a6126f1cc7c4284b6620108db06 /lib/smtp.c | |
| parent | 04ac54e1965041684fc1b6532eba90f58601264e (diff) | |
build: fix Codacy warnings
Reduce variable scopes and remove redundant variable stores.
Closes https://github.com/curl/curl/pull/3975
Diffstat (limited to 'lib/smtp.c')
| -rw-r--r-- | lib/smtp.c | 15 |
1 files changed, 5 insertions, 10 deletions
diff --git a/lib/smtp.c b/lib/smtp.c index 4a3462b84..e10d0fbfc 100644 --- a/lib/smtp.c +++ b/lib/smtp.c @@ -359,10 +359,8 @@ static CURLcode smtp_perform_helo(struct connectdata *conn) */ static CURLcode smtp_perform_starttls(struct connectdata *conn) { - CURLcode result = CURLE_OK; - /* Send the STARTTLS command */ - result = Curl_pp_sendf(&conn->proto.smtpc.pp, "%s", "STARTTLS"); + CURLcode result = Curl_pp_sendf(&conn->proto.smtpc.pp, "%s", "STARTTLS"); if(!result) state(conn, SMTP_STARTTLS); @@ -378,11 +376,10 @@ static CURLcode smtp_perform_starttls(struct connectdata *conn) */ static CURLcode smtp_perform_upgrade_tls(struct connectdata *conn) { - CURLcode result = CURLE_OK; - struct smtp_conn *smtpc = &conn->proto.smtpc; - /* Start the SSL connection */ - result = Curl_ssl_connect_nonblocking(conn, FIRSTSOCKET, &smtpc->ssldone); + struct smtp_conn *smtpc = &conn->proto.smtpc; + CURLcode result = Curl_ssl_connect_nonblocking(conn, FIRSTSOCKET, + &smtpc->ssldone); if(!result) { if(smtpc->state != SMTP_UPGRADETLS) @@ -645,10 +642,8 @@ static CURLcode smtp_perform_rcpt_to(struct connectdata *conn) */ static CURLcode smtp_perform_quit(struct connectdata *conn) { - CURLcode result = CURLE_OK; - /* Send the QUIT command */ - result = Curl_pp_sendf(&conn->proto.smtpc.pp, "%s", "QUIT"); + CURLcode result = Curl_pp_sendf(&conn->proto.smtpc.pp, "%s", "QUIT"); if(!result) state(conn, SMTP_QUIT); |