diff options
| author | Jay Satiro <raysatiro@yahoo.com> | 2019-11-30 03:29:36 -0500 |
|---|---|---|
| committer | Jay Satiro <raysatiro@yahoo.com> | 2019-12-01 19:01:02 -0500 |
| commit | 9c1806ae4684ec5ef1aeb39bb9f15cece1c27256 (patch) | |
| tree | 519c34c7411ae2afda27b38500f77d456bb8cad9 /lib/vquic | |
| parent | 0436d4438a9dbfd5dc1364de31281505c7915b25 (diff) | |
build: Disable Visual Studio warning "conditional expression is constant"
- Disable warning C4127 "conditional expression is constant" globally
in curl_setup.h for when building with Microsoft's compiler.
This mainly affects building with the Visual Studio project files found
in the projects dir.
Prior to this change the cmake and winbuild build systems already
disabled 4127 globally for when building with Microsoft's compiler.
Also, 4127 was already disabled for all build systems in the limited
circumstance of the WHILE_FALSE macro which disabled the warning
specifically for while(0). This commit removes the WHILE_FALSE macro and
all other cruft in favor of disabling globally in curl_setup.
Background:
We have various macros that cause 0 or 1 to be evaluated, which would
cause warning C4127 in Visual Studio. For example this causes it:
#define Curl_resolver_asynch() 1
Full behavior is not clearly defined and inconsistent across versions.
However it is documented that since VS 2015 Update 3 Microsoft has
addressed this somewhat but not entirely, not warning on while(true) for
example.
Prior to this change some C4127 warnings occurred when I built with
Visual Studio using the generated projects in the projects dir.
Closes https://github.com/curl/curl/pull/4658
Diffstat (limited to 'lib/vquic')
| -rw-r--r-- | lib/vquic/ngtcp2.c | 2 | ||||
| -rw-r--r-- | lib/vquic/quiche.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/lib/vquic/ngtcp2.c b/lib/vquic/ngtcp2.c index 7d8b98e90..c39dba23a 100644 --- a/lib/vquic/ngtcp2.c +++ b/lib/vquic/ngtcp2.c @@ -49,7 +49,7 @@ #ifdef DEBUG_HTTP3 #define H3BUGF(x) x #else -#define H3BUGF(x) do { } WHILE_FALSE +#define H3BUGF(x) do { } while(0) #endif /* diff --git a/lib/vquic/quiche.c b/lib/vquic/quiche.c index b2c98d255..e2f43237f 100644 --- a/lib/vquic/quiche.c +++ b/lib/vquic/quiche.c @@ -45,7 +45,7 @@ #ifdef DEBUG_HTTP3 #define H3BUGF(x) x #else -#define H3BUGF(x) do { } WHILE_FALSE +#define H3BUGF(x) do { } while(0) #endif #define QUIC_MAX_STREAMS (256*1024) |