aboutsummaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorDaniel Stenberg <daniel@haxx.se>2014-10-02 23:31:01 +0200
committerDaniel Stenberg <daniel@haxx.se>2014-10-02 23:31:01 +0200
commitb85c625d831de821d0e4ead3d01be2ffe955aa28 (patch)
treef70927e2d28d679904a17b9b87bdede3473a790c /lib
parent0d357155cc8b5132e33ee6d20b0a83aff872e58b (diff)
detect_proxy: fix possible single-byte memory leak
Coverity CID 1202836. If the proxy environment variable returned an empty string, it would be leaked. While an empty string is not really a proxy, other logic in this function already allows a blank string to be returned so allow that here to avoid the leak.
Diffstat (limited to 'lib')
-rw-r--r--lib/url.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/lib/url.c b/lib/url.c
index 69a75e310..0ee6fb042 100644
--- a/lib/url.c
+++ b/lib/url.c
@@ -4339,9 +4339,8 @@ static char *detect_proxy(struct connectdata *conn)
prox=curl_getenv(proxy_env);
}
- if(prox && *prox) { /* don't count "" strings */
+ if(prox)
proxy = prox; /* use this */
- }
else {
proxy = curl_getenv("all_proxy"); /* default proxy to use */
if(!proxy)