diff options
author | Dan Fandrich <dan@coneharvesters.com> | 2017-05-13 19:04:10 +0200 |
---|---|---|
committer | Dan Fandrich <dan@coneharvesters.com> | 2017-05-13 19:12:22 +0200 |
commit | fa0ac3f4d9ca095c33bca62ba2f64c95e3c3456a (patch) | |
tree | d74cd727f8292b96b4909ed24ec4f9b4de3e3d76 /tests/data/test1105 | |
parent | 6d49695bcabe14108056c429cffdaee950242318 (diff) |
tests: made a couple of prechecks consistent with others
Also removed a TODO suggesting caching the precheck results. Tests
showed this would save about 0.1 sec on the total test run time on a
relatively modern system, an unnoticeable gain at the cost of longer and
more complicated code. There would also be a danger that a cached test
result would be inappropriately returned, such as when other test
dependencies (like environment variables) are different or when the
precheck causes side effects (like filesystem changes).
Diffstat (limited to 'tests/data/test1105')
-rw-r--r-- | tests/data/test1105 | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/data/test1105 b/tests/data/test1105 index 76ac4500a..4b5e0c836 100644 --- a/tests/data/test1105 +++ b/tests/data/test1105 @@ -35,7 +35,7 @@ HTTP with cookie parser and header recording "http://%HOSTIP:%HTTPPORT/we/want/1105?parm1=this*that/other/thing&parm2=foobar/1105" -c log/cookie1105.txt -d "userid=myname&password=mypassword" </command> <precheck> -perl -e 'if ("%HOSTIP" !~ /127\.0\.0\.1$/) {print "Test only works for HOSTIP 127.0.0.1"; exit(1)}' +perl -e "print 'Test requires default test server host' if ( '%HOSTIP' ne '127.0.0.1' );" </precheck> </client> |