aboutsummaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorSteve Holme <steve_holme@hotmail.com>2013-09-08 20:16:49 +0100
committerSteve Holme <steve_holme@hotmail.com>2013-09-08 20:19:20 +0100
commit131649a1217c8653f54850645da56d3b559e7309 (patch)
treecb4d19fb91d3699bec8fde64d8c05d98498d384c /tests
parent632b3d81d6501108c13dd25f4d412e7e28ab3ad3 (diff)
ftpserver.pl: Corrected POP3 LIST as message numbers should be contiguous
The message numbers given in the LIST response are an index into the list, which are only valid for the current session, rather than being a unique message identifier. An index would only be missing from the LIST response if a DELE command had been issued within the same session and had not been committed by the end of session QUIT command. Once committed the POP3 server will regenerate the message numbers in the next session to be contiguous again. As such our LIST response should list message numbers contiguously until we support a DELE command in the same session. Should a POP3 user require the unique message ID for any or all messages then they should use the extended UIDL command. This command will be supported by the test ftpserver in an upcoming commit.
Diffstat (limited to 'tests')
-rw-r--r--tests/data/test8532
-rwxr-xr-xtests/ftpserver.pl2
2 files changed, 2 insertions, 2 deletions
diff --git a/tests/data/test853 b/tests/data/test853
index 934837f64..3d2a6712a 100644
--- a/tests/data/test853
+++ b/tests/data/test853
@@ -19,7 +19,7 @@ SLOWDOWN
<datacheck>
1 100
2 4294967400
-4 200
+3 200
</datacheck>
</reply>
diff --git a/tests/ftpserver.pl b/tests/ftpserver.pl
index 7fac030f0..902926791 100755
--- a/tests/ftpserver.pl
+++ b/tests/ftpserver.pl
@@ -1280,7 +1280,7 @@ sub LIST_pop3 {
my @data = (
"1 100\r\n",
"2 4294967400\r\n", # > 4 GB
- "4 200\r\n", # Note that message 3 is a simulated "deleted" message
+ "3 200\r\n",
);
logmsg "retrieve a message list\n";